Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Crash with read-only CDPATH

X-seq: zsh-workers 52986
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Cc: Connor Olding <cloningdonor@xxxxxxxxx>
Subject: Re: Crash with read-only CDPATH
Date: Tue, 2 Jul 2024 11:04:34 -0700
Archived-at: <https://zsh.org/workers/52986>
In-reply-to: <A4710344-95A0-48DC-BD1E-A4CCD1B08251@kba.biglobe.ne.jp>
List-id: <zsh-workers.zsh.org>
References: <CAD9VzoAct1RxG-TMYR2vxau+pTDt_5ZVQXjPgL3Wy5RaZueKcw@mail.gmail.com> <A4710344-95A0-48DC-BD1E-A4CCD1B08251@kba.biglobe.ne.jp>

On Tue, Jul 2, 2024 at 3:27 AM Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>
> If CDPATH (a special parameter) is made readonly, save_params()
> (called at exec.c:4071) does not allocate any memory for tpm,
> but the original pm (obtained by paramtab->getnode() at line 4410)
> is added to the restorelist (line 4442).
>
> I _guess_, in save_param(), we need to add tpm to restorelist
> only if a copy of pm (i.e., tpm) is allocated.
>
> Is this reasonable?

It looks reasonable to me, yes.  Thanks for investigating.

References:
- Crash with read-only CDPATH
  - From: Connor Olding
- Re: Crash with read-only CDPATH
  - From: Jun T

Messages sorted by: Reverse Date, Date, Thread, Author