On 7/14/24 7:22 PM, Oliver Kiddle wrote:
Eric Cook wrote:On 7/8/24 5:17 PM, Lawrence Velázquez wrote:On May 28, 2024, at 11:40 AM, Lyn Fugmann <me@xxxxxxxx> wrote: I finally got around to testing this. The behavior appears to depend only on the local version of rsync, not on the remote version. Tested using local rsync 3.2.3 and 3.2.7, remote rsync 3.1.3 and 3.2.7. So I think the patch should be fine as is. (I would expect very few people to run an over two years old version of rsync and a recent version of zsh on the same local machine.)A GitHub user is inquiring about the status of this contribution. https://github.com/zsh-users/zsh/pull/114#issuecomment-2212591419a possible fix, open to a better option letter for _remote_files than -Q, since compadd has -Q.-Q with compadd's meaning is unlikely to be useful with _remote_files so overloading it should be harmless enough. -O is the scp option to use the old protocol. Given that option, scp completion would ideally fallback to the old behaviour. Oliver
Committed the patch i submitted. I am unsure what changes, if any, that _scp needs.