Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [RFC PATCH 1/2] complete absolute paths for mpc add
- X-seq: zsh-workers 53236
- From: "Karel Balej" <balejk@xxxxxxxxx>
- To: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>
- Cc: <zsh-workers@xxxxxxx>
- Subject: Re: [RFC PATCH 1/2] complete absolute paths for mpc add
- Date: Mon, 11 Nov 2024 20:26:04 +0100
- Archived-at: <https://zsh.org/workers/53236>
- In-reply-to: <CAH+w=7YmmvYqdnNzbLRJd6y5pgNj0ceD=PhjeHiN4A5FtOf8jQ@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20240927163300.25833-1-balejk@matfyz.cz> <CAH+w=7az25SsJsydSC9_aNOJh16DHOqsgpWZ36FYbDUfF_m55Q@mail.gmail.com> <D5IQ82P71IOB.2WLM65LN09CG5@matfyz.cz> <CAH+w=7YmmvYqdnNzbLRJd6y5pgNj0ceD=PhjeHiN4A5FtOf8jQ@mail.gmail.com>
Bart Schaefer, 2024-11-10T15:10:55-08:00:
> On Sun, Nov 10, 2024 at 10:56 AM Karel Balej <balejk@xxxxxxxxx> wrote:
> >... possibly simpler to just have _mpc_helper_files fail on no matches
> > and have the completion fall back to _files only then?
>
> If, when _mpc_helper_files does find something, you don't mind
> skipping files that _mpc_helper_files does not find, you can certainly
> do that.
Actually that isn't really better because only absolute paths should be
completed via _files.
So if you have no further comments, I can submit the original patches
updated with the ret handling.
Thank you,
K. B.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author