Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Fix memory leak

X-seq: zsh-workers 53305
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Dimitris Apostolou <dimitris.apostolou@xxxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: Fix memory leak
Date: Fri, 3 Jan 2025 08:58:10 -0800
Archived-at: <https://zsh.org/workers/53305>
In-reply-to: <C49DA422-44DB-42B5-BF78-947029580DE2@icloud.com>
List-id: <zsh-workers.zsh.org>
References: <C49DA422-44DB-42B5-BF78-947029580DE2@icloud.com>

On Fri, Jan 3, 2025 at 8:36 AM Dimitris Apostolou
<dimitris.apostolou@xxxxxxxxxx> wrote:
>
> zsh/Src/Zle/zle_main.c:352:2: error: Common realloc mistake: 'kungetbuf' nulled but not freed upon failure [memleakOnRealloc]

This is a false positive.  kungetbuf can never be NULL here, it's
initialized in the setup_() function.  There's also no way for a
caller to recover from an out-of-memory condition here, so there's no
reason to free the old buffer -- the program is going to crash.

References:
- Fix memory leak
  - From: Dimitris Apostolou

Messages sorted by: Reverse Date, Date, Thread, Author