Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Fix return value of `realloc` not stored

X-seq: zsh-workers 53306
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Dimitris Apostolou <dimitris.apostolou@xxxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: Fix return value of `realloc` not stored
Date: Fri, 3 Jan 2025 09:06:06 -0800
Archived-at: <https://zsh.org/workers/53306>
In-reply-to: <0BF02875-7CEF-41D2-AFE5-A394DC780B10@icloud.com>
List-id: <zsh-workers.zsh.org>
References: <0BF02875-7CEF-41D2-AFE5-A394DC780B10@icloud.com>

On Fri, Jan 3, 2025 at 8:24 AM Dimitris Apostolou
<dimitris.apostolou@xxxxxxxxxx> wrote:
>
> zsh/Src/Modules/watch.c:567:7: error: Return value of allocation function 'realloc' is not stored. [leakReturnValNotUsed]

This also looks like a false positive to me, the analyzer has not
properly recognized that the assignment operator on line 566 stores
the value from the realloc() call on line 567.  Please explain how
your new code is functionally different from the previous code?

Also when submitting patches, please provide a prose rationale, rather
than just quoting a lint message.

Follow-Ups:
- Re: Fix return value of `realloc` not stored
  - From: Mikael Magnusson

References:
- Fix return value of `realloc` not stored
  - From: Dimitris Apostolou

Messages sorted by: Reverse Date, Date, Thread, Author