Re: [PATCH] Remove non-existing flags from _uniq

[Julian Prein <julian@xxxxxxxxxxxx>]

On 2025-01-22 02:34:18 +0100, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Tue, Jan 21, 2025 at 4:29 AM Julian Prein <julian@xxxxxxxxxxxx> wrote:
> >
> > I am not really accustomed to sending patches on mailing lists. Could you tell
> > me what the issues were exactly, so that it wont happen again?
>
> Content-Type: text/plain; charset=UTF-8; format=flowed
>
> The "flowed" formatting caused some lines to run together (because
> leading spaces) and others to wrap at 72 characters.

Interesting, I will look into that.

> > Also if I may ask: How does it work with the authorship of commits for the zsh
> > project? I noticed that you put my name in the subject - was there something for
> > me to do, to become the commit author?
>
> There's no hard and fast rule but long-standing practice from before
> we started using git (i.e., with CVS) was to credit the author in the
> ChangeLog file rather than in the commit log, because there was no
> convenient way to change the identity of the committer.
>
> Lately I've been using both the ChangeLog and the --author option when
> I commit a patch without any further adjustment, but only the
> ChangeLog when I have to make any other repairs.  However, I confess
> to sometimes forgetting to use --author.

That makes sense, understood.

Thanks a lot for taking the time to reply and explain!

Best,
Julian