Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Segfault upon interrupt of completion - opinions?

X-seq: zsh-workers 53359
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: Segfault upon interrupt of completion - opinions?
Date: Tue, 11 Feb 2025 10:02:06 -0800
Archived-at: <https://zsh.org/workers/53359>
In-reply-to: <CAH+w=7Y3HU12kKJC=9=cUUbeUCRpjT6zdvoAgDUcHfL0LKf1KA@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAH+w=7ZKqb-iy6AAeiU4viaX-5ho=zRTZ7Zfu+KOrRW_zKOUfw@mail.gmail.com> <CAH+w=7Y3HU12kKJC=9=cUUbeUCRpjT6zdvoAgDUcHfL0LKf1KA@mail.gmail.com>

On Sat, Feb 8, 2025 at 1:19 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Feb 8, 2025 at 1:08 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > Option 1:  zle_tricky.c:878 should not run the after-hooks on interrupt.
> >
> > Option 2:  runhookdef() should not run any hooks if there's been an
> > interrupt.  This probably has wide-reaching side effects, so doesn't
> > seem viable?
> >
> > Option 3:  Every hook function has to make its own decision about
> > interrupts.  We can fix this specific case in after_complete().
>
> Option 4: domenuselect() can be a no-op following interrupt.

As long as I'm soliciting advice -- what other ZLE state could/should
be checked here?  Possibly "resetneeded"?  Anything else?

Follow-Ups:
- Re: Segfault upon interrupt of completion - opinions?
  - From: Bart Schaefer

References:
- Segfault upon interrupt of completion - opinions?
  - From: Bart Schaefer
- Re: Segfault upon interrupt of completion - opinions?
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author