Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: _zarun:1: can't change option: vi

X-seq: zsh-workers 53371
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Eric Nielsen <ericbn@xxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: _zarun:1: can't change option: vi
Date: Mon, 17 Feb 2025 11:51:08 -0800
Archived-at: <https://zsh.org/workers/53371>
In-reply-to: <058650b0-58c5-4157-87e7-12e461f04b34@app.fastmail.com>
List-id: <zsh-workers.zsh.org>
References: <8dcc05e5ffacf2ddd6cdd51238affb7d440dda69@hey.com> <058650b0-58c5-4157-87e7-12e461f04b34@app.fastmail.com>

On Mon, Feb 17, 2025 at 11:37 AM Lawrence Velázquez <larryv@xxxxxxx> wrote:
>
> On Mon, Feb 17, 2025, at 10:29 AM, Eric Nielsen wrote:
> >      } else if ((optno == EMACSMODE || optno == VIMODE) && value) {
> > +       if (new_opts[optno] == value)
> > +           return 0;

new_opts is an output rather than an input.  It does point to the
global opts array most of the time, but testing it instead of using
the global is logically incorrect.

> https://www.zsh.org/mla/workers/2025/msg00070.html
>
> --
> vq

References:
- Re: _zarun:1: can't change option: vi
  - From: Eric Nielsen
- Re: _zarun:1: can't change option: vi
  - From: Lawrence Velázquez

Messages sorted by: Reverse Date, Date, Thread, Author