Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: query terminal properties on ZLE startup
- X-seq: zsh-workers 53381
- From: Oliver Kiddle <opk@xxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Cc: zsh-workers@xxxxxxx
- Subject: Re: PATCH: query terminal properties on ZLE startup
- Date: Tue, 25 Feb 2025 10:12:36 +0100
- Archived-at: <https://zsh.org/workers/53381>
- In-reply-to: <CAH+w=7Zf3vL6BYg0t61uskLmDD_gOwE7XhuwxB9SSwv+z0qOKw@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <42572-1740099942.836692@_3BM.v5Iz.JqiS> <F07C8421-2663-440A-82AD-0748D39511B1@kba.biglobe.ne.jp> <CAH+w=7a9hye-2BxQUjkHw-=zFo5T7vXjVwQRnKnKEoZ3W0-_ug@mail.gmail.com> <40483-1740433325.086036@2QZo.3hhS.-9FG> <CAH+w=7Zf3vL6BYg0t61uskLmDD_gOwE7XhuwxB9SSwv+z0qOKw@mail.gmail.com>
Bart Schaefer wrote:
> I was initially thinking from setup of the zleparameter module rather
> than the zle module, but I suppose these aren't strictly zle
> parameters?
Yes, if moved out to a different module it should probably be it's own module
rather than zleparameter.
> The other choice would be to wait until at least one of them was
> referenced, that is, make them autoloaded parameters instead of
> prepopulating them ... but I didn't parse the rest of the patch source
> closely so maybe that's not relevant.
That could be an option but after weighing pros/cons, I'd be inclined to
leave it as it is unless we find the query escape sequences cause major
problems or unless someone has some thoughts I haven't considered(?).
It's likely that we'll add C code which uses the results meaning there
wouldn't be a variable reference. The nearcolor autoload patch already
does this and I have a couple of further features in mind that would
also do this.
If done as part of a parameter autoload, we have little control over
when it happens. If it's inside a subshell, we might end up duplicating
the queries. Where I've seen issues in testing, these were display
artifacts and for those it is best to get them over with early at a
point where they're rapidly hidden.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author