Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] fix: do not complete indices for empty array subscripts
- X-seq: zsh-workers 53451
- From: Oliver Kiddle <opk@xxxxxxx>
- To: Kyle Andelin <andelink@xxxxxxxx>
- Cc: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] fix: do not complete indices for empty array subscripts
- Date: Fri, 04 Apr 2025 21:11:45 +0200
- Archived-at: <https://zsh.org/workers/53451>
- In-reply-to: <20250404145550.45523-1-andelink@kyle.foo>
- List-id: <zsh-workers.zsh.org>
- References: <20250404145550.45523-1-andelink@kyle.foo>
Kyle Andelin wrote:
> In the above, `arrbar` is empty and thus should not have any indices
> as completion choices. After applying the attached patch, we get the
> expected results:
Your fix and analysis of the problem cause look right to me. I've merged
your patch.
> First time contributor here so please let me know if there is anything I need
> to do different or if there are any changes you'd like to see. I also opened
> a PR on GitHub as I wasn't sure which would be preferred:
> https://github.com/zsh-users/zsh/pull/130
No this was perfect. No need to duplicate with both a list message and
PR. A list message is preferred, especially if you're changing a general
file like _subscript rather than a file in Completion/*/Command.
Thanks for the patch!
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author