Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

RE: Avoid strlen calls after sprintf



[Sorry for the late response.]

Haai,

On Tue, 28 Jan 2025 02:35:57 +0100, Oliver Kiddle <opk@xxxxxxx> wrote:
> This change makes use of the return value from sprintf instead of
> calling strlen on the resulting buffer.

That's sensible; however, as sprintf(3) can theoretically[0] return -1,
it's safer to do an error check before using the value for computation.

        --zeurkous.

[0] This could actually happen if the format string is somehow invalid;
    in that case, the mistake won't trigger alarm bells but silently
    add a value of -1 if left unchecked. Eek.

-- 
Friggin' Machines!




Messages sorted by: Reverse Date, Date, Thread, Author