Re: [bug] :P modifier and symlink loops

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Thu, Apr 24, 2025 at 11:36 AM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> >
> > Patch six in this series breaks whence -s, I guess it is not a very
> > common usecase since nobody complained until now.
> > Expected:
> > % Src/zsh -c 'which -s git'
> > /usr/bin/git
> > Actual:
> > % Src/zsh -c 'which -s git'
> > /usr/bin/git -> /usr/bin/git
> >
> > Reverting the patch seems to resolve the issue, but I'm not sure what
> > the intent of the change was in the first place

Eliminate excess work done by xsymlinks, I think.

> > I know that Daniel isn't very active anymore, but if anyone else has
> > any thoughts?

We could resolve the issue without adding back the xsymlnks call if we
could tell that chrealpath has returned the exact same path it was
given.