Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH 1/3: Fix buffer overflow and wrong behavior in url_encode

X-seq: zsh-workers 54497
From: Philippe Altherr <philippe.altherr@xxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: PATCH 1/3: Fix buffer overflow and wrong behavior in url_encode
Date: Thu, 7 May 2026 11:35:05 +0200
Arc-authentication-results: i=1; mx.google.com; arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=ewQVPOQpRm2R8dDMU6rax6dxhZNtFoc3bK6qaqSOH5A=; fh=5z4hNn4LCRbKTd1i4UBG0Xwg24Rjg1Dy3aTvDwPYAzg=; b=g+CPbrxg3kIFdvwODjWiprHjO48QknkE5ZN8wvHq5ElPvDx4gNVrbDEhkRjfEm9F7y Yw2Hws4DuadsdifhBpNgrXrvexW01nwRWYUreiA7fxcPRzwaOHe1FUFbEsqfcJ0a+mzm t2kU5wgdQpOlkE7w5/E3eAUi59vR1WpIqDYT7JU7kRcEz/nLkJDbdKHk1Cl3M8G/VZe7 mxVFNOWCt5+dmEQ9C8rRVrP/hHawSqQkVgKrqNzBOBpfjbOJK5xRKg255EaPDMowI6/j H6vVxQ2MsqI8kuxbvYCRN+89Bl/iAd6fubpHTUXLC/KXJ4GFh9U2wgLIki4unHQGOKIv P7kQ==; darn=zsh.org
Arc-seal: i=1; a=rsa-sha256; t=1778146517; cv=none; d=google.com; s=arc-20240605; b=gIMDlQUvhaXlmG8HiFlDwO/U+4dBafZaQEpUpY29A/uMTSrf84wNkZbeBitUYZRdUr 4d+KKRyY+Wz0Es4kmvvlSj378AIU3GbBwhbHlj3fdtC+y5ai0892ngFadw86V3cPMnK+ kRyHqLjoDX0HWvuPXZcsxn4cFJ24cWPIC/ZK6SoeAZT7IT9ajtMhpEwy9QuGy9BP6Ibw jYS4XWtwM5pBoeW2yNLteNGEAP8KOn61lPtV/63B3HlMKt3YxYiHXUjx+ZJcRu7PsjWP YG/mLGrTkrvjZh7tKdXLLko83sPtC/ytjle+PuYO5Z8C1NZseclqIV7cdDcQb939tql3 MSTA==
Archived-at: <https://zsh.org/workers/54497>
In-reply-to: <20260507035927.29370-1-mikachu@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20260507035927.29370-1-mikachu@gmail.com>

"const unsigned char *in" looks very weird to me. Wouldn't it be possible to cast "*in" in the call to sprintf:

out += sprintf(out, "%%%02X", (unsigned char)*in);

or maybe

out += sprintf(out, "%%%02X", *in & 0xFF);

Philippe

Follow-Ups:
- Re: PATCH 1/3: Fix buffer overflow and wrong behavior in url_encode
  - From: Mikael Magnusson

References:
- PATCH 1/3: Fix buffer overflow and wrong behavior in url_encode
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author