Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] tests: improve readability

On Fri, Jun 5, 2026 at 7:50 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Jun 5, 2026 at 10:14 AM Philippe Altherr
> <philippe.altherr@xxxxxxxxx> wrote:
> >>
> >> My recommendations/wishes:
> >>
> >> Put at least the main summary line and the star lines in bold
> >> Use more fine grained coloring for the summary line (see results of my sed command)
> >> Put the star lines in red if there are any failures and otherwise in green (and maybe in cyan if there are only skipped files)
> >
> > I forgot the most useful: use a third color to highlight messages, like ones for skipped test files/cases, that are neither error nor success messages. Without highlighting, I have a hard time noticing these messages.
> >
> > Philippe
> >
>
> My only input on this:
>
> Please do take non-interactive builds into account.  We've had people
> who build binary distribution packages report issues with the test
> suit before.
>
> Rather than make a lot of changes to the test output itself, maybe
> create something like Philippe's sed as a coprocess to filter the
> output (and then using that only for interactive sessions).

On Fri, Jun 5, 2026 at 10:28 AM Peter Stephenson
<p.w.stephenson@xxxxxxxxxxxx> wrote:
> One bane of my life in other tests systems is that files are full
> of escape sequences because they don't take account of the difference between interactive and non-interactive contexts,
> so I'm forever running my remove-escapes Emacs function, but from
> what you say you might well have thought of that already.

The code checks [[ -t 1 ]] to gate coloring the output, so this
shouldn't be a problem.

-- 
Mikael Magnusson
Messages sorted by: Reverse Date, Date, Thread, Author