Re: PATCH: avoid problem with deleting nameref features in modules

[Philippe Altherr <philippe.altherr@xxxxxxxxx>]

The change in module.c is no longer needed (an equivalent change was done in 54475: Don't perform dereferencing when looking up certain special parameters). The change in Modules/ksh93.c is still welcome but a little more can be deleted. Here is an updated patch.

Philippe

diff --git a/Src/Modules/ksh93.c b/Src/Modules/ksh93.c
index 95a69bc43..f365e5ae2 100644
--- a/Src/Modules/ksh93.c
+++ b/Src/Modules/ksh93.c
@@ -267,18 +267,7 @@ boot_(Module m)
 int
 cleanup_(Module m)
 {
-    struct paramdef *p;
-
     deletewrapper(m, wrapper);
-
-    /* Clean up namerefs, otherwise deleteparamdef() is confused */
-    for (p = partab; p < partab + sizeof(partab)/sizeof(*partab); ++p) {
-	if (p->flags & PM_NAMEREF) {
-	    HashNode hn = gethashnode2(paramtab, p->name);
-	    if (hn)
-		((Param)hn)->node.flags &= ~PM_NAMEREF;
-	}
-    }
     return setfeatureenables(m, &module_features, NULL);
 }