Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Don't segfault when uniquifying hidden tied arrays

X-seq: zsh-workers 55003
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Don't segfault when uniquifying hidden tied arrays
Date: Sun, 19 Jul 2026 20:17:40 -0700
Arc-authentication-results: i=1; mx.google.com; arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=oxH8zofz/+iYTqCg5mT+MiaNAIEEByWIjkFqWofswGE=; fh=BgAYDYpL6Ne/A5nWEMVJiHiBtrz8Imz3uf26RDwgQX4=; b=p3EjIjL4Thpum4VwW7IwVukJIIZbsKmbq3jo9KvZXV4Z6yOgbafsY4oRHdsbidOkDf DLSongJK2FBtLS/d249J0N7yg0YmyrcfGg1vjZ4PJyG3Uu0OO7vocZK37YzcOqjET3bf gCsR4nkhzTQ2DrLSWZrFtRc67qlTDRtoR5kNjwoo3bhjcoonMxJh4cTOoKjnL/daL+M2 MhYdjhwzdzPcqMK2zXBCKwZgbRrNRsxdbkkiD1i1HfnBKP7ylHxvn5o0CKhbTvaDq1zK v3NvTpKAfxW9aumRQhICqyRChSLhzU9CKNmA59DABzQdKUl3w9/g3V+sZjbppL8Jz2Zb DGUg==; darn=zsh.org
Arc-seal: i=1; a=rsa-sha256; t=1784517472; cv=none; d=google.com; s=arc-20260327; b=lbH8w1mneKEnqV3+HmQ3+XxG8WlOxuKweb4aeVJBIDqgzqffrlJqMGOdrS/JXrfM4f e3wkCv8xW4tsSKiIKOrwcSD+fED74iCjYYd5GolpnT94GOtWH5qZf3k8xwiJAXMOPJrC 9pwdNeFJ33jdJYZvi7ceYsp05rGXs37SMnBh/OUe2j2vi3BxYzoN8YdSSwoPLY9ss+51 v2KjCbWrD/XMIMrr2uzPBa7JgjwIBhbHKNwHLNLhcBs+mBfo5Owj++6H01ZpnGU3GWJh itFaQpVXZAtjrnG1C2yBfKeRmFK0A1HNuFM6CJht1t1C6RRazAxJM+m5QQ3jdSjAGkhw tLPQ==
Archived-at: <https://zsh.org/workers/55003>
In-reply-to: <CAGdYchsZEkiDqMzwae6B0NhPG+mTGcSk+snEHjSj6iYwM-TC=Q@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAGdYchsZEkiDqMzwae6B0NhPG+mTGcSk+snEHjSj6iYwM-TC=Q@mail.gmail.com>

On Sun, Jul 19, 2026 at 7:28 PM Philippe Altherr
<philippe.altherr@xxxxxxxxx> wrote:
>
> - (Param) paramtab->getnode(paramtab, pm->ename))) {
> - x = (*apm->gsu.a->getfn)(apm);
> +    } else if (PM_TYPE(pm->node.flags) == PM_SCALAR && pm->ename) {
> + x = *(pm->node.flags & PM_SPECIAL
> +      ? (char ***)pm->u.data
> +      : ((struct tieddata *)pm->u.data)->arrptr);

Just checking ... apm->gsu.a->getfn can return the static &nullarray
to guarantee the result is never NULL.

Are you confident that pm->u.data is never NULL or a pointer to NULL here?

Follow-Ups:
- Re: [PATCH] Don't segfault when uniquifying hidden tied arrays
  - From: Philippe Altherr

References:
- [PATCH] Don't segfault when uniquifying hidden tied arrays
  - From: Philippe Altherr

Messages sorted by: Reverse Date, Date, Thread, Author