Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Can I do without "eval" here?
- X-seq: zsh-users 10014
- From: "Com MN PG P E B Consultant 3" <mn-pg-p-e-b-consultant-3.com@xxxxxxxxxxx>
- To: "zsh-users Mailinglist" <zsh-users@xxxxxxxxxx>
- Subject: Can I do without "eval" here?
- Date: Tue, 14 Mar 2006 10:03:51 +0100
- Mailing-list: contact zsh-users-help@xxxxxxxxxx; run by ezmlm
- Thread-index: AcZHRja08lXTdb20RjyfSSeSljOBQQ==
- Thread-topic: Can I do without "eval" here?
Maybe just a matter of style, but here is a (simplified) version of a
problem which
I have solved, but where I am not satisfied with the solution ...
Assume I have a command CMD which can be called in the following ways:
CMD -x FILENAME
CMD -y 'this is some string with alphanumerics and spaces' FILENAME
I call this CMD from a skript MYSCRIPT. If the skript is called with 1
parameter, I use the second form and put the
parameter into the argument of my -y option. If MYSCRIPT is called
without parameters, I use the -x option.
For sake of simplicity, we can assume that the FILENAME is always
hardcoded. That is, if someone calls
MYSCRIPT without any arguments, i.e.
MYSCRIPT
it should execute
CMD -x foo
But if MYSCRIPT is called like this:
MYSCRIPT "bar baz"
it should execute
CMD -y 'bar baz' foo
Here is my solution (which I ask you to improve):
#!/bin/zsh
if [[ $# -eq 0 ]]
then
options=-x
else
options="-y '$1'"
fi
eval CMD $options foo
The 'eval' is necessary here, because if I write just
CMD $options foo
CMD would see for example -y 'bar baz' as first argument, and not just
-y.
What I don't like in this example, is the usage of eval. Although it is
harmless in this particular case,
the filename 'foo', which is hardcoded here, comes in as a parameter too
in my real application, and
this means that it undergoes one level of evaluation too, which would
yield wrong results when it contains,
say, a $ character.
Of course one might argued that when you are thinking of filenames with
$, you are doomed anyway, but
still I'm not a big fan of using 'eval' anyway, so I wonder whether this
can be done without eval
too....
Ronald
Messages sorted by:
Reverse Date,
Date,
Thread,
Author