Re: Patch available for 3.0.6-pre-0

[Wayne Davison <wayne@xxxxxxxxx>]

"Bart Schaefer" writes:
> I'd appreciate feedback from anyone who grabs it and applies it.

I've compiled it and am checking it out now.  So far so good.

One thing I think would be nice to achieve for the 3.0.6 release is
to remove all the warnings when building zsh with gcc 2.8.1.  To
this end, I have tweaked the source and generated a diff from your
pre-0 release.  The patch is about 22k, so I won't include it here.
Anyone who wants it can grab it via the web:

    http://www.clari.net/~wayne/zsh-3.0.6-pre-0.patch

The changes were simply adding a bunch of braces to various if
blocks, and changing a few character-subscript values into unsigned-
character subscripts.

Some of the added braces were to enclose some one-line macros that
consist of an "if ... else ..."  block.  This makes it look like some
of the ifs have braces that are enclosing only one line.  I suppose
I'd prefer to see these macros get changed from this:

    if (...) {
        cmdpop();
    }

into this:

    if (...)
        CMDPOP

(so that CMDPOP could be written using curly braces), but that was
beyond the scope of my simple patch.

You may also notice that I added a few extra brace sets to some
indented-code blocks that were right near where I was already adding
braces.  I did this because I think that the code reads better when
multi-line blocks of indented code are enclosed in braces (even when
they aren't absolutely required), and because it seemed to me that
this is consistent with the latest coding style (e.g. the while loop
in the new read1char() function).

> * I haven't decided what to do with RCS $Id$ keywords.

I for one would not miss them if they were removed, but I don't
feel strongly about this.

..wayne..