Re: Nasty bug in array-element typeset assignments

[Oliver Kiddle <opk@xxxxxxxxxxxxx>]

Borsenkow Andrej wrote:
> 
> Commit log does not have article number, but diffs are here:

Going by the commit date, I can't find an associated message in the
archives.

> > Really? So what would it do? Make the whole foo array local or just the
> > first element? Clearly neither works.
> 
> Probably, intent was to create new local array.

Urgh. Is that really that useful? I think it'd be better to save the
extra mess in the code and disallow it with roughly what you get by
adding this:

       } else if (on & PM_LOCAL && locallevel) {
           zerrnam(cname,
                   "%s, can't create local array elements", pname, 0);
           return NULL;

after the similar bit for readonly inside the strchr(pname, '[') test in
typeset_single.

Also, if this is fixed to make the whole array local but the fix is
complicated then this small change might be a good option for the 4.0
branch.

Incidentally, I get a couple of test failures with the latest CVS - on
with _arguments and the other for posixbuiltins.

Oliver