Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: configure tests for iconv
- X-seq: zsh-workers 20924
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Zsh workers <zsh-workers@xxxxxxxxxx>
- Subject: Re: configure tests for iconv
- Date: Thu, 03 Mar 2005 14:51:13 +0100
- In-reply-to: <200503031126.j23BQmXE002473@xxxxxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <5964.1109263147@xxxxxxxxxxxxxxxxxxxxx> <200503011246.j21CkRGS031240@xxxxxxxxxxxxxx> <31072.1109700154@xxxxxxxxxxxxxxxxxxxxxxx> <200503021608.j22G8ips020857@xxxxxxxxxxxxxx> <28818.1109848253@xxxxxxxxxxxxxxxxxxxxxxx> <200503031126.j23BQmXE002473@xxxxxxxxxxxxxx>
Peter wrote:
> OK, Cygwin now converts characters up to and including 0x7f. After that
Good. Thanks for your help with this.
> Would it be worth changing the error message for that error (the second
> one in the iconv branch) to suggest the error was with the particular
> character, rather than with character sets in general?
When using wctomb() instead of iconv() it actually prints "character not
in range" for that situation so it certainly makes sense that we should
be consistent with that.
Oliver
--- utils.c.bak 2005-03-03 14:45:33.772178204 +0100
+++ utils.c 2005-03-03 14:45:36.562694413 +0100
@@ -3637,7 +3637,7 @@ getkeystring(char *s, int *len, int from
count = iconv(cd, &inptr, &inbytes, &t, &outbytes);
iconv_close(cd);
if (count == (size_t)-1) {
- zerr("cannot do charset conversion", NULL, 0);
+ zerr("character not in range", NULL, 0);
*t = '\0';
*len = t - buf;
return buf;
Messages sorted by:
Reverse Date,
Date,
Thread,
Author