Re: PATCH: new shells completion type

[Doug Kearns <dougkearns@xxxxxxxxx>]

On Wed, Jun 22, 2005 at 03:59:20PM +0200, Oliver Kiddle wrote:
> Doug Kearns wrote:
> > Here is a new completion type for shells. It seems to me that if we're
> > going to complete shells from /etc/shells then it should be restricted
> > _only_ to shells listed there. This will change the behaviour of useradd
> > completion which always included /bin/false.
> 
> With useradd/usermod, it's very useful to have /bin/false as a match. If
> the user account won't need to login then that's a common way to ensure
> it can't.

Right, but it was my understanding that these commands were supposed to
check /etc/shells, if it existed, and fail if the shell arg isn't listed
there. Also, that /bin/false was generally added to this file if it was
required. However, a quick check on my system suggests that although
chsh does behave as described above useradd/usermod do not...
 
> > -  '-s[shell to execute rather than $SHELL]:shell name: _command_names -e' \
> > +  '-s[shell to execute rather than $SHELL]:shell:_shells' \
> 
> I don't use screen but does that option only get used with actual
> shells?

I think you're right the definition of 'shell' may well be less strict
than that - I'll have a look.
 
<snip>

Regards,
Doug