Re: PATCH: test output to terminal dehackery

[Peter Stephenson <pws@xxxxxxx>]

Bart Schaefer wrote:
> On May 29,  3:43pm, Peter Stephenson wrote:
> }
> } We now have the technology to open a file descriptor for test input and
> } terminal output without using up one of the standard shell ones.
> } The {fd}<redir> syntax opens up an unused fd from 10 on.
> 
> Hrm.  I'm ambivalent about this patch.  The {fd}< syntax is one of the
> things that gets tested for correctness quite a bit later on.  If it
> doesn't work properly here, could the whole test suite fail?
> 
> That is, I'm wondering if the implementation of the test suite should
> restrict itself to the most basic shell operations possible and only
> the tests themselves employ extended functionality.

I don't really believe in the division between basic and extended
functionality, except as regards add-ons; if the shell's broken it needs
fixing.  You're correct that the new syntax isn't used as much so it's
more likely it would get broken without anyone noticing.  I don't see
any implication beyond needing to fix that before running other
tests, however; that can in principle happen with anything.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview