Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Fix a typo in _git.
- X-seq: zsh-workers 25481
- From: "Mikael Magnusson" <mikachu@xxxxxxxxx>
- To: zsh-workers <zsh-workers@xxxxxxxxxx>
- Subject: Re: Fix a typo in _git.
- Date: Tue, 19 Aug 2008 02:09:38 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Gd6OYiq6FQcGwHuDRThDEZ3Odd9j4DveS9RqPjBvBq0=; b=GCnz8cQjDYsZHYmHZWlAYI0kiMdIZipJUHiozewN71xvVnaLC9jQ8sti+Q+Y4xuiHF 9wMSnJOFBp+0Ili6pQpf4E/I1fSdZaqWNzDyJ8ncZvO1vNv3NPv4BgTxHHoxt1W0fzRm m6YPBxn1Bs4RWhoJvGKvwDmnXVtgSM84EVTnw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=f6h/TpIS04lSN9UBvVoQNruVNy44ybZLVaNcTwkeb2EjoeZLMF90w6j6FiGIVOvnHA gY/pabPc41vOt3ZkCLFfz8Q4bpN/Fnk/IKnAF7OvsYtUspc/B77qqxX2IGBWj4OlAc4i X0FIbCBpk/j9+Lipnl5qE/J/4rPXO0yN12LVg=
- In-reply-to: <20080818224510.GA12825@xxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <237967ef0808151656j7787f169g4b3456910e05bfc2@xxxxxxxxxxxxxx> <20080817171321.GA24334@xxxxxxxx> <237967ef0808171027t4773ff36nb1cfe08942b63a5f@xxxxxxxxxxxxxx> <20080818014613.GA30193@xxxxxxxx> <237967ef0808180247l7b0ed485ob72df0a0637c57e9@xxxxxxxxxxxxxx> <237967ef0808181310kfa7128bt2e0321e77ad96d8f@xxxxxxxxxxxxxx> <20080818224510.GA12825@xxxxxxxx>
Oooh, that was tricky :).
2008/8/19 Clint Adams <clint@xxxxxxx>:
> On Mon, Aug 18, 2008 at 10:10:40PM +0200, Mikael Magnusson wrote:
>> Now that I actually rebased my stuff on top of latest cvs, and include
>> _call_program, I notice what I think is the reason I removed it: It
>> doesn't work. Does it work for you? It's kind of weird, all the other
>> _call_program in _git work fine, just the three git for-each-ref don't.
>> And they work fine with the _call_program \S+ removed...
>
> Oops.
>
> Index: Completion/Unix/Command/_git
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
> retrieving revision 1.78
> diff -u -r1.78 _git
> --- Completion/Unix/Command/_git 18 Aug 2008 01:55:29 -0000 1.78
> +++ Completion/Unix/Command/_git 18 Aug 2008 22:43:19 -0000
> @@ -2972,7 +2972,7 @@
> local expl
> declare -a branch_names
>
> - branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='%(refname)' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/})
> + branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='"%(refname)"' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/})
> __git_command_successful || return
>
> _wanted heads expl branch-name compadd $* - $branch_names HEAD
> @@ -2983,7 +2983,7 @@
> local expl
> declare -a tag_names
>
> - tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='%(refname)' refs/tags 2>/dev/null)"}#refs/tags/})
> + tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='"%(refname)"' refs/tags 2>/dev/null)"}#refs/tags/})
> __git_command_successful || return
>
> _wanted tags expl tag-name compadd $* - $tag_names
> @@ -3036,7 +3036,7 @@
> local expl
> declare -a branch_names
>
> - branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='%(refname)' refs/heads 2>/dev/null)"}#refs/heads/})
> + branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='"%(refname)"' refs/heads 2>/dev/null)"}#refs/heads/})
> __git_command_successful || return
>
> _wanted branch-names expl branch-name compadd $* - $branch_names
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author