Re: fc (history) requires zsh is interactive? Why can't interactive toggled?

[Peter Stephenson <pws@xxxxxxx>]

On Mon, 22 Sep 2008 23:31:51 -0400
"Rocky Bernstein" <rocky.bernstein@xxxxxxxxx> wrote:
> I removed the interact test and played around with fc and don't see
> any difference.

I'm really only concerned with the non-interactive behaviour, which
probably only you have probed, so if you're happy with it there's probably
nothing major to worry about.

> Attached should be a two-line patch to #ifdef this code out. Apply it.
> If people find problems in fc as a result of this change, I'll fix
> these. If we get to a release and people for whatever reason feel the
> that life was better disallowing fc unless in interactive mode, then
> it is a matter of deleting two lines and you have the old behavior.

It seems unlikely that will be necessary if you haven't fallen over
anything horrible.

> I will also remove the interactive flag on zshdb as another means of
> getting test coverage there with a program that uses fc without
> interactive mode set.
>
> And to show good faith in fixing whatever bugs come up, attached is a
> test in an new "fc" file for the bug I recently discovered which by
> the way has nothing to do with whether or not interactive is set.

Thanks, both very useful.  I've committed both the changes.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070