Re: fc (history) requires zsh is interactive? Why can't interactive toggled?

["Rocky Bernstein" <rocky.bernstein@xxxxxxxxx>]

Many thanks!

(If you are in a hurry the rest can be safely skipped.)

I think for those who care about such things -- attaching to a running
non-interactive script and setting up an interactive terminal with
history--  this will be an improvement. No doubt this is a very small
(if not negligible) number. So for those who don't, I don't think the
change will be a drag.

I see a typo in dump history in B06fc.ztst: "dump history" => "dump
when history". I've been writing English just about all of my life and
I still manage to bungle sentences like this.

However sometime before a release I should add more fc test cases, in
addition to any issues that arise down the line. I suspect that (and
dread the time when)  folks take issue with how history is handled in
zshdb (or not handled) and how it interacts when there is interactive
history in the debugged the program.

But with more test cases and more coverage, hopefully we will come to
a better understanding in how this or some particular change effects
things and more confidence that making changes of this kind while
assuring it doesn't break things for others.

So thanks again.

On Tue, Sep 23, 2008 at 4:42 AM, Peter Stephenson <pws@xxxxxxx> wrote:
> On Mon, 22 Sep 2008 23:31:51 -0400
> "Rocky Bernstein" <rocky.bernstein@xxxxxxxxx> wrote:
>> I removed the interact test and played around with fc and don't see
>> any difference.
>
> I'm really only concerned with the non-interactive behaviour, which
> probably only you have probed, so if you're happy with it there's probably
> nothing major to worry about.
>
>> Attached should be a two-line patch to #ifdef this code out. Apply it.
>> If people find problems in fc as a result of this change, I'll fix
>> these. If we get to a release and people for whatever reason feel the
>> that life was better disallowing fc unless in interactive mode, then
>> it is a matter of deleting two lines and you have the old behavior.
>
> It seems unlikely that will be necessary if you haven't fallen over
> anything horrible.
>
>> I will also remove the interactive flag on zshdb as another means of
>> getting test coverage there with a program that uses fc without
>> interactive mode set.
>>
>> And to show good faith in fixing whatever bugs come up, attached is a
>> test in an new "fc" file for the bug I recently discovered which by
>> the way has nothing to do with whether or not interactive is set.
>
> Thanks, both very useful.  I've committed both the changes.
>
> --
> Peter Stephenson <pws@xxxxxxx>                  Software Engineer
> CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
> Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070
>