Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Updates to git completion

X-seq: zsh-workers 26478
From: Mikael Magnusson <mikachu@xxxxxxxxx>
To: Richard Hartmann <richih.mailinglist@xxxxxxxxx>
Subject: Re: [PATCH] Updates to git completion
Date: Thu, 29 Jan 2009 15:40:36 +0100
Cc: Ingmar Vanhassel <ingmar@xxxxxxxxxxx>, "Zsh Hackers' List" <zsh-workers@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=eAmffThQ1a3lG66Ah3ICnHkwhiWTq1PJE7yAWp+pbkk=; b=m9RYle2LYcAO2tihcwC8Qdq5p9eOwvkLRqH5rOSiFT4djyQwzAJfK0+VGHwPD0CLoP anmhqsJsZ1rbftRDzf1Y3iXznbIus7J01oS9D6p9upaAp/qwx70oP2t5V0hNupAjWJmZ J7ZQejJzqUpgkilBLdZfgKaWJ/zQPSjj1ctC4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=cY7VYhoWnPcP9vui1KlgZ9srFHWpmZHt3a2feXgDtd4nrfekTGeoNGd0n1SKsesmPe AlqERnabHKrwcjUB5hph9f1ldUhxmyoVLv44EeVhWKmooZCwUrpjFVu1UHhWWAQj8KSq 1TjBKRbIcgtvrJzl0lwc04Ds1BKX7uwjV+iUk=
In-reply-to: <2d460de70901290636g6e0b43fw971397716cba8886@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <1233231710-1204-1-git-send-email-ingmar@xxxxxxxxxxx> <2d460de70901290636g6e0b43fw971397716cba8886@xxxxxxxxxxxxxx>

2009/1/29 Richard Hartmann <richih.mailinglist@xxxxxxxxx>:
> On Thu, Jan 29, 2009 at 13:21, Ingmar Vanhassel <ingmar@xxxxxxxxxxx> wrote:
>
>> I've started working on updating the git completion for command line
>> changes in git 1.6.0 & newer.
>
> Ah, sorry, I should have read all emails on this list before answering.
>
> First of all: Thanks & welcome :)
>
>
> If you are adding/changing things which are not valid for older versions
> of git, you might want to check the git version and act depending on
> that.
> From looking over the patches (_not_ trying them!), they seem to
> make sense (provided that git has those options ;)

I think trying to complete options for the right versions for ~130
commands could make the
code just a bit convoluted and hard to follow. Not even git itself
documents when options
were introduced.

-- 
Mikael Magnusson

Follow-Ups:
- Re: [PATCH] Updates to git completion
  - From: Doug Kearns
- Re: [PATCH] Updates to git completion
  - From: Richard Hartmann

References:
- [PATCH] Updates to git completion
  - From: Ingmar Vanhassel
- Re: [PATCH] Updates to git completion
  - From: Richard Hartmann

Messages sorted by: Reverse Date, Date, Thread, Author