Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Updates to git completion

X-seq: zsh-workers 26508
From: Doug Kearns <dougkearns@xxxxxxxxx>
To: "Zsh Hackers' List" <zsh-workers@xxxxxxxxxx>
Subject: Re: [PATCH] Updates to git completion
Date: Tue, 3 Feb 2009 21:44:17 +1100
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=T3i/i7aL2cJfO7gO195jOp4Si9hPLFMwYP2e3x4qcb4=; b=BzmxcAyOi7TVWxDWdwJH4G3myjUkW5G5d7DrybTIAFlycY/VsofgCTor/sBUMLsHq2 1Uid5KgigrYz7t/AA5mm3MFWnivDaAuVBQ0f5rG21Bf8DanOd54ugIJm08LeGkM428mw N6lEUUutwkb98r8V7eJ1TlCvRDnhP3zxlp3GY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=xNN4LN2Tqlee1NeLWASTw8PpcOpZz80OJn6E6gwjW9D509aUjG60BtUDlj6uRhJ4GR T+H4r9hOdD13QLpBq8BHYD2YDKyWwD7P+Pr3Z2yQ3Bst4Dih1o0VOs4BbaBDMFxUL9Dz qZoWcEAkgjip/9l4sNEkS5miStS2kqlGQNkxQ=
In-reply-to: <237967ef0901290640u9adf073g204586c1b290d0@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <1233231710-1204-1-git-send-email-ingmar@xxxxxxxxxxx> <2d460de70901290636g6e0b43fw971397716cba8886@xxxxxxxxxxxxxx> <237967ef0901290640u9adf073g204586c1b290d0@xxxxxxxxxxxxxx>

On 1/30/09, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> 2009/1/29 Richard Hartmann <richih.mailinglist@xxxxxxxxx>:

<snip>

>  > If you are adding/changing things which are not valid for older versions
>  > of git, you might want to check the git version and act depending on
>  > that.
>  > From looking over the patches (_not_ trying them!), they seem to
>  > make sense (provided that git has those options ;)
>
>
> I think trying to complete options for the right versions for ~130
>  commands could make the
>  code just a bit convoluted and hard to follow. Not even git itself
>  documents when options
>  were introduced.

Right.  In general only the latest version is supported.  This is
documented in Etc/completion-style-guide.

Regards,
Doug

References:
- [PATCH] Updates to git completion
  - From: Ingmar Vanhassel
- Re: [PATCH] Updates to git completion
  - From: Richard Hartmann
- Re: [PATCH] Updates to git completion
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author