Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
File completion of scp (tentative fix)
- X-seq: zsh-workers 29912
- From: Ignacy Gawędzki <zsh@xxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: File completion of scp (tentative fix)
- Date: Wed, 23 Nov 2011 01:21:50 +0100
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
Hi,
It's been some time since I wanted to track this bug down and finally took the
time to do it.
Supposing you have a remote host with a file in the home directory that begins
with a dash, the completion may fail because the file argument is interpreted
by ls as an option.
See the attached patch, which adds a -- before the pattern, so that files
starting with a dash won't possibly be considered as options. This is the way
to go with a GNU ls on the other side, but I don't know how other versions
will interpret that. Maybe something more sophisticated has to be done to
remain as generic as possible.
--
Save the whales. Feed the hungry. Free the mallocs.
diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
index d0944c6..0ec9c84 100644
--- a/Completion/Unix/Command/_ssh
+++ b/Completion/Unix/Command/_ssh
@@ -16,7 +16,7 @@ _remote_files () {
then rempat="${PREFIX%%[^./][^/]#}\*"
else rempat="${(q)PREFIX%%[^./][^/]#}\*"
fi
- remfiles=(${(M)${(f)"$(_call_program files ssh -o BatchMode=yes $args -a -x ${IPREFIX%:} ls -d1FL "$rempat" 2>/dev/null)"}%%[^/]#(|/)})
+ remfiles=(${(M)${(f)"$(_call_program files ssh -o BatchMode=yes $args -a -x ${IPREFIX%:} ls -d1FL -- "$rempat" 2>/dev/null)"}%%[^/]#(|/)})
compset -P '*/'
compset -S '/*' || suf='remote file'
Messages sorted by:
Reverse Date,
Date,
Thread,
Author