Re: Certain unicode in hostname breaks with zsh 4.3.17

[Peter Stephenson <Peter.Stephenson@xxxxxxx>]

On Mon, 12 Mar 2012 10:07:37 -0700
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Mar 12, 11:10am, Peter Stephenson wrote:
> >
> > @@ -739,7 +741,7 @@ createparamtable(void)
> >  			pm->env = mkenvstr (pm->node.nam,
> >  					    getsparam(pm->node.nam), pm->node.flags);
> >  		    else
> > -			pm->env = ztrdup(*envp2);
> > +			pm->env = ztrdup_metafy(*envp2);
> >  #ifndef USE_SET_UNSET_ENV
> >  		    *envp++ = pm->env;
> >  #endif
> 
> I'm not sure that's correct.  pm->env is being copied directly into the
> global environ array in the USE_SET_UNSET_ENV case.

Yes, you're right, so that shouldn't be metafied and I'll correct that
bit.

-- 
Peter Stephenson <pws@xxxxxxx>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog