Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] vcs_info git: Fix stagedstr for empty repos
- X-seq: zsh-workers 32663
- From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] vcs_info git: Fix stagedstr for empty repos
- Date: Mon, 02 Jun 2014 15:19:34 +0200
- In-reply-to: <20140602130028.GD1871@tarsus.local2> (Daniel Shahaf's message of "Mon, 2 Jun 2014 13:00:28 +0000")
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20140601022653.GE1820@tarsus.local2> <87vbsj4tk1.fsf@ft.bewatermyfriend.org> <20140602130028.GD1871@tarsus.local2>
Daniel Shahaf wrote:
[...]
>> I'm with Aaron on this one. IIRC, git uses the diff-index command in
>> various places, so I don't think it'll be removed anytime soon.
>
> My concern was not with using diff-index but with using the empty tree.
> Since Aaron says using it would be robust, let's just use it. Attached.
I see. I suppose this would only change, if git decides to change its
hashing algorithm. That's a problem for another day, I guess. :)
>> If you don't want the second variant to be forgotten, you can always put
>> it into the change's commit message. But in the code I'd just use the
>> variant that you think is faster (if only theoretically).
>
> It's mentioned in this thread, good enough for me.
Great, thanks! Pushed.
Regards, Frank
Messages sorted by:
Reverse Date,
Date,
Thread,
Author