Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [patch] _init_d add OpenBSD bits
- X-seq: zsh-workers 37589
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Matthew Martin <phy1729@xxxxxxxxx>
- Subject: Re: [patch] _init_d add OpenBSD bits
- Date: Wed, 13 Jan 2016 00:57:34 +0000
- Cc: zsh-workers@xxxxxxx
- In-reply-to: <20160110190157.GA4187@CptOrmolo.darkstar>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20160110190157.GA4187@CptOrmolo.darkstar>
Matthew Martin wrote on Sun, Jan 10, 2016 at 13:01:57 -0600:
> + (( $+functions[_init_d_get_cmds] )) ||
> + _init_d_get_cmds() {
> + local -a cmds disabled
> +
> + cmds=(start stop reload restart check)
> + disabled=(${${${(M)${(f)"$(< $script)"}:#rc_(${(~j:|:)cmds})=NO}#rc_}%=NO})
Enhancement idea: only populate $disabled if -f isn't on the command line.
(This doesn't block the patch, in my opinion.)
> + echo ${cmds:|disabled}
> + }
> +
> + flags=('-d[print debug information]' '-f[forcibly start the daemon]')
> else
> (( $+functions[_init_d_fullpath] )) ||
> _init_d_fullpath() {
> @@ -90,4 +107,4 @@ cmds=( $(_init_d_get_cmds) ) || return
> (( $#cmds )) || zstyle -a ":completion:${curcontext}:commands" commands cmds ||
> cmds=(start stop)
>
> -_sub_commands $cmds
> +_arguments -s -A "-*" $flags "*:init.d command:_sub_commands $cmds"
Surely these should be single quotes around the last argument?
Messages sorted by:
Reverse Date,
Date,
Thread,
Author