Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [patch] _init_d add OpenBSD bits
- X-seq: zsh-workers 37599
- From: Matthew Martin <phy1729@xxxxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [patch] _init_d add OpenBSD bits
- Date: Tue, 12 Jan 2016 22:47:56 -0600
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=npfWWWqfms/eUhxu/w9agw+NnMgA045tAMrmY6hA5XM=; b=aZMu3QTxCfylyplW+86p35T/jiuLAK7xGi8mLKGvzP2hjhF6XlK/wYwd9e2YuOZ58A 9Kp4vbEwa1wZtnEXu0zFbFqaBsmS+eTfTq05eEUofHyd2ZEU3GK9NpKBIpYIKJbpiOG9 siVGY2LpPrnJjUfxn6EsTxOAFEIn8sF0nqzCBK3jau5gmqaTbyQejQGU9XWCD15lKDZB 6RDJFnicxCeMgwl7hRJ+E/9Nh04IfydlkxE3UEAlCkJ6aTC5sEG9jZtz3Vb7UIgX6tff xNAUCtY6pZ1bxRXDgBh1rqguYMCD0EPxwDg7V5TtbaYqNJD185Bi4Y1HQxp1PRkJS6kr hvqw==
- In-reply-to: <20160113005734.GA24858@tarsus.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20160110190157.GA4187@CptOrmolo.darkstar> <20160113005734.GA24858@tarsus.local2>
On Wed, Jan 13, 2016 at 12:57:34AM +0000, Daniel Shahaf wrote:
> Matthew Martin wrote on Sun, Jan 10, 2016 at 13:01:57 -0600:
> > + (( $+functions[_init_d_get_cmds] )) ||
> > + _init_d_get_cmds() {
> > + local -a cmds disabled
> > +
> > + cmds=(start stop reload restart check)
> > + disabled=(${${${(M)${(f)"$(< $script)"}:#rc_(${(~j:|:)cmds})=NO}#rc_}%=NO})
>
> Enhancement idea: only populate $disabled if -f isn't on the command line.
> (This doesn't block the patch, in my opinion.)
-f overrides <daemon>_flags=NO for the start action like FreeBSD's
onestart. It doesn't override the rc_<action>=NO statements.
>
> > + echo ${cmds:|disabled}
> > + }
> > +
> > + flags=('-d[print debug information]' '-f[forcibly start the daemon]')
> > else
> > (( $+functions[_init_d_fullpath] )) ||
> > _init_d_fullpath() {
> > @@ -90,4 +107,4 @@ cmds=( $(_init_d_get_cmds) ) || return
> > (( $#cmds )) || zstyle -a ":completion:${curcontext}:commands" commands cmds ||
> > cmds=(start stop)
> >
> > -_sub_commands $cmds
> > +_arguments -s -A "-*" $flags "*:init.d command:_sub_commands $cmds"
>
> Surely these should be single quotes around the last argument?
Indeed! I didn't realize _arguments parses it's arguments.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author