Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock
- X-seq: zsh-workers 42189
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock
- Date: Sat, 30 Dec 2017 09:44:28 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=sHhvHy5i4dh6tpnL9xiffvnA5lZ6EqPs3grFgUoMhm0=; b=jSF6+8DA60a/0uxvI2lnJa5LWISwL+v8s2gP9nnMl4zuQkvyV8wc5Ied+Hcl+zha9f JTDSd6d/rV1vorkzYLfKg1haTWk7AigDyYAYuEcBsxmbKHrHoOJDdXx9LbfrpTY8A1Fj /Z7NA7bVnHQI/oWCiY7nTD35kSNBosaPgKyWC0qGyyTxpUMD1DA/bMeZbUcsR1l8wjkR +g66laRvcZibh5502IVoHk2kHhH0MsLUWnT6ukuEpSuc+8aYHfsOdAYnIu8V+U8SeBFi 6V/F0oii01juxCaQ85vuRx8gY0u0bFmgByikl6ne9Ly71JFraNw34yxVsCyAWwpXM3jY /e8A==
- In-reply-to: <etPan.5a47b193.2c35fec7.13d7@zdharma.org>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <etPan.5a47b193.2c35fec7.13d7@zdharma.org>
On Sat, Dec 30, 2017 at 7:32 AM, Sebastian Gniazdowski
<psprint@xxxxxxxxxxx> wrote:
> The patch adds preceding zclose(flock_fd) to all return 1 and return 2 code paths.
Nothing wrong with the patch but the original code structure looks
funny. Why do we return without calling zwarnnam() when errflag? I
suppose the assumption is that it only gets set if we already output
some other error message?
Messages sorted by:
Reverse Date,
Date,
Thread,
Author