Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock

Not very online at the moment so please excuse format but I think you'll find there's somewhere a test so we don't output messages when errflag is already set (but it could be in some other code path than the one you're talking about).

pws

On 30 December 2017 17:44:28 GMT+00:00, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>On Sat, Dec 30, 2017 at 7:32 AM, Sebastian Gniazdowski
><psprint@xxxxxxxxxxx> wrote:
>> The patch adds preceding zclose(flock_fd) to all return 1 and return
>2 code paths.
>
>Nothing wrong with the patch but the original code structure looks
>funny.  Why do we return without calling zwarnnam() when errflag?  I
>suppose the assumption is that it only gets set if we already output
>some other error message?

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Messages sorted by: Reverse Date, Date, Thread, Author