Re: support more arguments to diff

[Matthew Martin <phy1729@xxxxxxxxx>]

On Tue, Apr 17, 2018 at 04:22:38AM -0700, Eitan Adler wrote:
> On 16 April 2018 at 07:59, Daniel Tameling <tamelingdaniel@xxxxxxxxx> wrote:
> > On Sun, Apr 15, 2018 at 10:48:08PM -0700, Eitan Adler wrote:
> >> This patch isn't perfect since {Net,DragonFly,Open,Free}BSD are not
> >> identical but this patch at leasts makes the completion a lot closer
> >> to reality.
> >>
> >> Currently FreeBSD doesn't even show -q for example.
> >>
> >
> > Did the patch change the behavior of diff completion for you? On my
> > FreeBSD, diff is some GNU variant, and I think that it's the default
> > and that I didn't install it via pkg:
> 
> FreeBSD is in the process of converting to a new diff implementation.
> This resulted in me seeing a huge difference with this patch.
> 
> I'd also like to port this particular diff implementation to the other
> BSDs, hence adding all of them to the case statement.

I think it would be best to add the other cases as each BSD adopts
whichever diff. I generally try to update the completion to match
-current, so when a new release is picked up the options are correct.

> > I think the reason why there is only openbsd in the else branch is
> > that all the other ship with some kind of GNU diff. (At least that is
> > what the online man pages of dragonfly and netbsd indicate.) However,
> > the versions seem to differ wildly across BSDs.
> 
> Makes sense from a historical point of view.

I think the real reason is I only bothered to update OpenBSD completion
when I sent the patch. I usually shoot for [DFNO]BSD now.

- Matthew Martin