Re: [PATCH] rewrite _killall

[dana <dana@xxxxxxx>]

On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>+if _pick_variant psmisc=PSmisc unix --version; then

Is this OK? I know it's checking for killall5/Solaris early on, but is there any
possibility that a SysV-style killall could slip past that check? Maybe that's
overly paranoid, idk.

On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>+    '(-n --ns)'{-n,--ns}'[match against the PID namespace of the given PID]:pid: _pids'

Trivial thing, but it seems preferable to let _pids, _signals, &c., handle their
descriptions unless there's a specific need to override them, yeah?

On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>+    '(-g --process-group)'{-g,--process-group}'[kill the process group to which the process blongs]'
>+    '(-s --signal)'{-s,--signal}'[send the speified signal]:signal:_signals'
>+    '-m[interprit specified name as a regular expression]'
>+    '-s[show only what will be done, but do notsend any signal]'

Some typos here:

* blongs -> belongs
* speified -> specified
* interprit -> interpret
* notsend -> not send

On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>'(-u --user)'{-u,--user}'[kill only processes owned by specified user]: : _users'
>+    '-u[limit to processes belonging to specified user]: :_users'

These should all be in -o+ and --opt= form, i'd think.

On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>+  _arguments -s -S : $args

`-A '-*'` would be appropriate for this one.

dana