Re: [PATCH] rewrite _killall

[Jun T <takimoto-j@xxxxxxxxxxxxxxxxx>]

Thank you for the comments.

> 2018/06/28 23:52、dana <dana@xxxxxxx>のメール:
> 
> On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>> +if _pick_variant psmisc=PSmisc unix --version; then
> 
> Is this OK? I know it's checking for killall5/Solaris early on, but is there any
> possibility that a SysV-style killall could slip past that check? Maybe that's
> overly paranoid, idk.

I guess on virtually all Linux distros killall comes from psmisc, and if it is
ever not psmics, I think the chances are very low that it is a SysV-variant.

> On 28 Jun 2018, at 02:39, Jun T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>> +    '(-n --ns)'{-n,--ns}'[match against the PID namespace of the given PID]:pid: _pids'
> 
> Trivial thing, but it seems preferable to let _pids, _signals, &c., handle their
> descriptions unless there's a specific need to override them, yeah?

The :pid: was doing nothing due to the space before _pids.
I will remove it.