Re: MODERATE for zsh-announce@xxxxxxx

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Peter Stephenson wrote on Wed, Sep 05, 2018 at 09:07:09 +0100:
> On Wed, 5 Sep 2018 09:54:15 +0200
> Baptiste Daroussin <bapt@xxxxxxxxxxx> wrote:
> > In case it might help others, the solution to fix the issue and have a working
> > runhelp was to remove the Doc/help.txt file from the sources after extracting
> > the tar file.
> 
> Hmm... the help files are supposed to be in the source rather than the
> doc distribution, so logically that should be there (along with the help
> files themselves).
> 

I've compared the 5.5.1 artifacts (known good) to the 5.6 artifacts.

The doc tarball adds Etc/FAQ.html, likely due to workers/43333.

The src tarball omits Doc/help/*.

> help.txt gets removed by realclean rather than clean, I think because
> it's part of the source.
> 
> Possibly we need to build from realclean when making a tarball.

For the 5.6 artifacts I did an out-of-tree build in an empty builddir after
`git clean -fdx` in the srcdir.  The "out-of-tree" part is the problem (I just
did another targz-{src,doc} build to confirm that).

For now, I'll add a note to the rolling-a-release runbook to run the tarball
build in a clean tree using an in-tree build.  (I don't have time to fix
Doc/Makefile.in right this minute.)

Sorry for the regression.

Daniel