Re: W02jobs.ztst hangs with zsh 5.6.1

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

> On 10 September 2018 at 12:32 İsmail Dönmez <ismail@xxxxxxxx> wrote:
> Inded that doesn't fail when I manually run it. I put the W02 under a
> loop to see if I can get it to fail more but surprisingly it failed
> elsewhere:
> 
> Running test: suspended job with check_jobs + check_running_jobs
> ZTST_test: expecting status: 0
> Input: /tmp/zsh.ztst.8136/ztst.in, output:
> /tmp/zsh.ztst.8136/ztst.out, error: /tmp/zsh.ztst.8136/ztst.terr
> 
> So indeed this could be a zpty problem in the end.

Thanks for that.

I'll disable the tests that attempt to test suspended jobs and see where that
gets us.

diff --git a/Test/W02jobs.ztst b/Test/W02jobs.ztst
index 1e7ac76..fe12f97 100644
--- a/Test/W02jobs.ztst
+++ b/Test/W02jobs.ztst
@@ -85,27 +85,29 @@
 *>zsh:*running jobs*
 *>zsh:*SIGHUPed*
 
-  zpty_start
-  zpty_input 'setopt check_jobs no_check_running_jobs'
-  zpty_input 'sleep 3'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_stop
-0:suspended job with check_jobs + no_check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
-
-  zpty_start
-  zpty_input 'setopt check_jobs check_running_jobs'
-  zpty_input 'sleep 3'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_stop
-0:suspended job with check_jobs + check_running_jobs
-*>zsh:*(stopped|suspended)*sleep*
-*>zsh:*(stopped|suspended) jobs*
-# no 'SIGHUPed' message for suspended jobs
+#### Races presumed to be associated with zpty mean that
+#### tests involving suspending jobs are not safe.
+##   zpty_start
+##   zpty_input 'setopt check_jobs no_check_running_jobs'
+##   zpty_input 'sleep 3'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_stop
+## 0:suspended job with check_jobs + no_check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
+## 
+##   zpty_start
+##   zpty_input 'setopt check_jobs check_running_jobs'
+##   zpty_input 'sleep 3'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_stop
+## 0:suspended job with check_jobs + check_running_jobs
+## *>zsh:*(stopped|suspended)*sleep*
+## *>zsh:*(stopped|suspended) jobs*
+## # no 'SIGHUPed' message for suspended jobs
 
   zpty_start
   zpty_input 'sleep 5 & sleep 4 & sleep 3 &'
@@ -153,19 +155,19 @@
 *>-
 *>zsh:*SIGHUPed*
 
-  zpty_start
-  zpty_input 'sleep 5'
-  sleep 0.1
-  zpty_input $'\C-z'
-  zpty_input 'jobs -r'
-  zpty_input 'print -- -'
-  zpty_input 'jobs -s'
-  zpty_stop
-0:`jobs -r` and `jobs -s` with suspended job
-*>zsh:*(stopped|suspended)*sleep*
-*>-
-*>\[1]  + (stopped|suspended)*sleep*
-# no 'SIGHUPed' message for suspended jobs
+##   zpty_start
+##   zpty_input 'sleep 5'
+##   sleep 0.1
+##   zpty_input $'\C-z'
+##   zpty_input 'jobs -r'
+##   zpty_input 'print -- -'
+##   zpty_input 'jobs -s'
+##   zpty_stop
+## 0:`jobs -r` and `jobs -s` with suspended job
+## *>zsh:*(stopped|suspended)*sleep*
+## *>-
+## *>\[1]  + (stopped|suspended)*sleep*
+## # no 'SIGHUPed' message for suspended jobs
 
   zpty_start
   zpty_input 'sleep 10 & sleep 9 & sleep 8 & sleep 7 &'