Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: zathura conpletion for zsh broken

Am 25.09.18 um 21:21 schrieb Daniel Shahaf:
> Oliver Freyermuth wrote on Tue, Sep 25, 2018 at 17:14:04 +0200:
>> +++ b/Completion/X/Command/_zathura
>> @@ -25,7 +25,7 @@ _zathura_files(){
>>      elif [[ $pf =~ "poppler" ]]; then
>>        supported_filetypes+="pdf"
>>      else
>> -      supported_filetypes+="${${pf%.so}#${plugins_dir}/lib}"
>> +      supported_filetypes+="${${pf%.so}#${plugins_dir}/}"
> 
> Isn't this equivalent to «supported_filetypes+=${pf:t:r}»?

Indeed, it is, and that would be much easier. 

> 
> The 'break' on line 12 looks odd.  Does zathura really ignore
> /usr/lib/zathura/foo.so if /usr/local/lib/zathura/bar.so exists and
> /usr/local/lib/zathura/foo.so does not?

You are correct in spotting this, if I read the zathura code correctly (not a girara expert...),
it "does the right thing" and searches the full list of paths. 

I'll try to cook up a patch fixing both those issues. Might take a while though, since
I'm just starting with this (basically I started to investigate after "zathura <tab>" stopped
doing anything after a zsh upgrade, makinɡ usage rather cumbersome). 

Thanks for the pointers!
	Oliver

> 
> Thanks,
> 
> Daniel
>
Messages sorted by: Reverse Date, Date, Thread, Author