Re: zathura conpletion for zsh broken

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Oliver Freyermuth wrote on Tue, 25 Sep 2018 22:02 +0200:
> Am 25.09.18 um 21:21 schrieb Daniel Shahaf:
> > Oliver Freyermuth wrote on Tue, Sep 25, 2018 at 17:14:04 +0200:
> >> +++ b/Completion/X/Command/_zathura
> >> @@ -25,7 +25,7 @@ _zathura_files(){
> >> -      supported_filetypes+="${${pf%.so}#${plugins_dir}/lib}"
> >> +      supported_filetypes+="${${pf%.so}#${plugins_dir}/}"
> > 
> > Isn't this equivalent to «supported_filetypes+=${pf:t:r}»?
> 
> Indeed, it is, and that would be much easier. 

Pushed.  I changed the log message to avoid mentioning implementation
terms (the variable's name) in ChangeLog, which is user-facing.

> > The 'break' on line 12 looks odd.  Does zathura really ignore
> > /usr/lib/zathura/foo.so if /usr/local/lib/zathura/bar.so exists and
> > /usr/local/lib/zathura/foo.so does not?
> 
> You are correct in spotting this, if I read the zathura code correctly
> (not a girara expert...), it "does the right thing" and searches the
> full list of paths.
> 
> I'll try to cook up a patch fixing both those issues. Might take a
> while though, since I'm just starting with this (basically I started
> to investigate after "zathura <tab>" stopped doing anything after a
> zsh upgrade, makinɡ usage rather cumbersome).

Thanks for the patch and looking into the additional issue.

Cheers,

Daniel

P.S. Our of curiosity, what's that U+0261 LATIN SMALL LETTER SCRIPT G doing there?

> Thanks for the pointers!
> 	Oliver