Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute
- X-seq: zsh-workers 43821
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- Subject: Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute
- Date: Mon, 12 Nov 2018 14:38:26 +0100
- Cc: Zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Rz1OVAHrZ67UxuVcVTyNu6+6Y8X7RZ0JnOPOyf/UTw4=; b=WXetYcvKJFjF5DLChviJuLABDFZK4Ea7Wz50LwehVoKfPGXtnmOdnbckSc2NJJg1iO LBh9F6X41txuSWhbsTKnCcZSR6dCcORHzs0kLpr2W/Bjo5Fd3M0Te/rZCNtoUJqAZ+Nt X8JEjrbCrvd6t8jxOQtY93it+KD8O6KmELO0Qt9n2aP5u78a3f/Ch1jeaPZRLVBQPXt4 vUWolCxYibHYIu5aJ4ZANhv+kDjV5fcQABmWEntZZe12qZkVE5CsmV996i4HSloYjTPz 50UAv2Pr11CdLN1FL2p9UXbBFPozwRr1NNzWqUcVmFkiiuiY9tAgbQFp0hIP5m09l8oV IzFA==
- In-reply-to: <48216-1541900650.063823@-d-s.vJ6h.N9Zv>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <48216-1541900650.063823@-d-s.vJ6h.N9Zv>
On 11/11/18, Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> gcc allows the -Wsuggest-attribute option to be repeated because it can
> be used with each of the four possible values.
>
> Oliver
>
> diff --git a/Completion/Unix/Command/_gcc b/Completion/Unix/Command/_gcc
> index 8687adc6e..1052967c7 100644
> --- a/Completion/Unix/Command/_gcc
> +++ b/Completion/Unix/Command/_gcc
> @@ -628,7 +628,7 @@ args+=(
> '-Wstrict-selector-match[Warn if type signatures of candidate methods do
> not match exactly]'
> '-Wstringop-overflow[Warn about buffer overflow in string manipulation
> functions like memcpy and strcpy. Same as -Wstringop-overflow=]'
> '-Wsubobject-linkage[Warn if a class type has a base or a field whose
> type uses the anonymous namespace or depends on a type with no linkage]'
> - '-Wsuggest-attribute=-[Warn about functions which might be candidates for
> __attribute__((const))]:const:(pure const noreturn format)'
> + '*-Wsuggest-attribute=-[warn about functions which might be candidates
> for __attribute__((const))]:const:(pure const noreturn format)'
> '-Wsuggest-final-methods[Warn about C++ virtual methods where adding
> final keyword would improve code quality]'
> '-Wsuggest-final-types[Warn about C++ polymorphic types where adding
> final keyword would improve code quality]'
> '-Wsuggest-override[Suggest that the override keyword be used when the
> declaration of a virtual function overrides another]'
Is there a specific reason you changed "Warn" to be lower case
inconsistent with all the other descriptions here?
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author