Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute
- X-seq: zsh-workers 43822
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Mikael Magnusson <mikachu@xxxxxxxxx>
- Subject: Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute
- Date: Tue, 13 Nov 2018 12:29:12 +0100
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Cc: Zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1542108556; bh=Ry8J/zJ7CTn2ER5XdbOmVSwFSEz7o6tZKwtP72dY0j8=; h=From:References:To:Subject:Date:From:Subject; b=gkzbe6K6a6EzPf7d0XcRU18+cQ07kJ3GVF89Tisfa+df6Rvk/3982f65K5SCX2sE8DBcdPqVLOFFoFnZ72nX1yqj5GWXOMyBTj0RbaH5gyutszicyZU/fSb7vBk5/k8PpWUDTq+2nYsX1P3kZExgknyemrTvtHJXxLUSBhcnFBV2dloVo+WR2O9FC17DlLQaacGmmB8vB7QYWf5dFiJGmIQE4HAQwKhOuFfi2pvIzbrrgx8LSoVuZLpA6B+n4X2xZRVqAZ3O6/KLTl0pbeVX8eb+3tKGKAFCWquTNMxKkm++SD9zpeMtXnDDInDNoRqElj7oPPpoRPN1aviECsnqGA==
- In-reply-to: <CAHYJk3TBacH7jOv0UXpgXu8NeP0AnAue5Qhav3shi8_HfDovZQ@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <48216-1541900650.063823@-d-s.vJ6h.N9Zv> <CAHYJk3TBacH7jOv0UXpgXu8NeP0AnAue5Qhav3shi8_HfDovZQ@mail.gmail.com>
Mikael Magnusson wrote:
> Is there a specific reason you changed "Warn" to be lower case
> inconsistent with all the other descriptions here?
Lower case is the normal convention for completion functions and I
apply corrections for common things like that on lines that I'm
otherwise modifying. I can see that in this particular case, it is
rather less than ideal because there's a lot of similar options.
The trouble with big patches to correct things like case and indentation
is that they obscure history in git.
In the case of gcc, I'd be inclined to treat warnings as a single -W
option that takes an argument:
'*-W-[enable/disable a warning]:warning:->warnings'
Then parse the output of gcc --help=warnings and strip off the then
superfluous "Warn (about|when|if) " part of the descriptions.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author