Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Change handrolled strftime to strftime in zftp.c



Sorry, the problem is not the OFF_T_IS_64_BIT but the comparison
in DPUTS().

I will push Wesley Schwengle's patch (with strftime --> ztrftime)
without the following because the two are no related.


diff --git a/Src/Modules/zftp.c b/Src/Modules/zftp.c
index 4aaa1f072..b3fbeae17 100644
--- a/Src/Modules/zftp.c
+++ b/Src/Modules/zftp.c
@@ -2518,7 +2518,8 @@ zftp_local(UNUSED(char *name), char **args, int flags)
 #ifdef OFF_T_IS_64_BIT
 	printf("%s %s\n", output64(sz), mt);
 #else
-	DPUTS(sizeof(sz) > 4, "Shell compiled with wrong off_t size");
+	DPUTS(sizeof(sz) > sizeof(long), 
+	      "Shell compiled with wrong off_t size");
 	printf("%ld %s\n", (long)sz, mt);
 #endif
 	zsfree(mt);






Messages sorted by: Reverse Date, Date, Thread, Author