Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Change handrolled strftime to strftime in zftp.c

X-seq: zsh-workers 44175
From: "Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Change handrolled strftime to strftime in zftp.c
Date: Mon, 25 Mar 2019 22:07:13 +0900
In-reply-to: <1553517734.6561.2.camel@samsung.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <20190323101135.14344-1-wesley@mintlab.nl> <20190323101135.14344-2-wesley@mintlab.nl> <CGME20190325121427epcas4p18e794aebecc4f574c6abc701a2080eba@epcas4p1.samsung.com> <A7DCA44C-CF98-4A56-8B82-ECAF78337F51@kba.biglobe.ne.jp> <1553517734.6561.2.camel@samsung.com>

> 2019/03/25 21:42, Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
>>  
>> Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"?
> 
> The obvious test would be
> 
> #ifdef ZSH_64_BIT_TYPE

But ZSH_64_BIT_TYPE is defined only if long is 32 bit
so we still get 'Shell compiled with wrong off_t size'.
Do you mean "#ifndef ZSH_64_BIT_TYPE"?

Follow-Ups:
- Re: [PATCH] Change handrolled strftime to strftime in zftp.c
  - From: Peter Stephenson
- Re: [PATCH] Change handrolled strftime to strftime in zftp.c
  - From: Jun T.

References:
- [PATCH 0/1] Fix -Wformat-overflow= warnings in zftp.c
  - From: Wesley Schwengle
- [PATCH] Change handrolled strftime to strftime in zftp.c
  - From: Wesley Schwengle
- Re: [PATCH] Change handrolled strftime to strftime in zftp.c
  - From: Jun T
- Re: [PATCH] Change handrolled strftime to strftime in zftp.c
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author