Re: [PATCH] Change handrolled strftime to strftime in zftp.c

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

> On 25 March 2019 at 13:07 "Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> > 2019/03/25 21:42, Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
> >>  
> >> Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"?
> > 
> > The obvious test would be
> > 
> > #ifdef ZSH_64_BIT_TYPE
> 
> But ZSH_64_BIT_TYPE is defined only if long is 32 bit
> so we still get 'Shell compiled with wrong off_t size'.
> Do you mean "#ifndef ZSH_64_BIT_TYPE"?

I don't see how that could work since output64() wouldn't exist.

I think this means the error message in the other branch is now redundant --- if
long is a 64-bit value it's perfectly OK to use that code.  Could change the DPUTS
check to check sizeof(sz) for that purpose instead?

pws