Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Bart Schaefer wrote on Fri, 20 Mar 2020 10:20 -0700:
> On Fri, Mar 20, 2020 at 10:03 AM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > The "limit" builtin is provided by a module.  As such, it can be
> > unavailable if the module had been disabled in config.modules prior to
> > building.
> >
> > Proposed patch:
> >
> > +  if grep '^name=zsh/rlimits .* link=no ' $ZTST_testdir/../config.modules >/dev/null  
> 
> Wouldn't it be better to test this with "zmodload" rather than attempt
> to examine the build config?

That was my first instinct too, but I just copied what V07pcre.ztst
did.  If using zmodload is better, then that file should probably be
updated to that approach too.

Cheers,

Daniel