Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Jun T wrote on Wed, 25 Mar 2020 09:16 +0900:
> > 2020/03/24 11:43, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > 
> > Jun T wrote on Tue, 24 Mar 2020 10:33 +0900:  
> >> 
> >> I get the error message 'duplicate ulimit option letter' every time
> >> I start zsh. This may be quite annoying for ordinary users.  
> > 
> > That message is printed by the DPUTS1() macro.  
> 
> Whoops, sorry.
> 
> I think only someone here (zsh-workers) will add a new resource, and
> I believe they will run the tests (but not sure they use
>  --enable-zsh-debug). So just adding a test is sufficient, I think.
> 

Okay, I'll commit the test from 45590, then, and leave the rest out.

> > 2020/03/21 2:02, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> >   
> >> + limit | grep UNKNOWN || print OK  
> > 
> > The "limit" builtin is provided by a module.  As such, it can be
> > unavailable if the module had been disabled in config.modules prior to
> > building.  
> 
> So what the fix for this? Is it enough to skip the tests if loading
> rlimits module fails (because we are testing module features, not
> module loading)?

Yes, I think so.  The patch in 45591 will take care of testing that
zmodload succeeds.  With that patch, B12limit.ztst can just do
«if ! zmodload …; ZTST_unimplemented=…» like all other V*ztst files:
zmodload errors will be caught by 45591.

Cheers,

Daniel