Re: [PATCH] Enable sub-second timeout in zsystem flock

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Cedric Ware wrote on Tue, 14 Apr 2020 22:21 +0200:
> Hopefully this patch can now be integrated, unless there are new
> issues?

The issues I've raised before have all been addressed (other than the
new nits below); however, I haven't done a line-by-line review.

dana, would you happen to have time to review the Cedric's latest
revision (workers/45690)?  No problem if not; just asking since you
reviewed earlier revisions.

Cedric Ware wrote on Mon, 13 Apr 2020 23:34 +0200:
> +++ b/Doc/Zsh/mod_system.yo
> @@ -196,9 +196,16 @@ item(tt(zsystem flock -u) var(fd_expr))(
> +(Note: var(timeout) must be less than 2^30-1 seconds (about 34 years);
> +and var(interval) must be less than 0.999 * LONG_MAX microseconds
> +(only about 35 minutes on 32-bit systems).)

The semicolon feels out of place.  (Might be just me, though.)

> +++ b/Test/V14system.ztst
> @@ -0,0 +1,150 @@
> +# Test zsh/system module
> +
> +%prep
> +
> +  if zmodload -s zsh/system && zmodload -s zsh/zselect; then
> +    tst_dir=V13.tmp

s/V13/V14/

>

Cheers,

Daniel