Re: [PATCH] Enable sub-second timeout in zsystem flock

[dana <dana@xxxxxxx>]

On 14 Apr 2020, at 20:15, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> dana, would you happen to have time to review the Cedric's latest
> revision (workers/45690)?

I'm not sure i fully understand the implications of the 32-vs-64-bit stuff,
nor whether it matters enough to go to all the extra trouble. But aside from
that and the two bits you mentioned (agreed on the semicolon), the only thing
i noticed is that there are several instances where the formatting of the new
C code doesn't match its surroundings, e.g. unnecessary brackets in
((foo < bar) || (baz > qux)) and inconsistent white space in foo? bar : baz

Otherwise i think it makes sense, as far as i understand it, and the tests
pass on my machine. I don't see any functional issues

dana